Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[locale] en-au: Sunday is changed as first day of week #5264

Merged
merged 9 commits into from May 19, 2020
Merged

[locale] en-au: Sunday is changed as first day of week #5264

merged 9 commits into from May 19, 2020

Conversation

vigneshwar33
Copy link
Contributor

@vigneshwar33 vigneshwar33 commented Oct 19, 2019 •
edited

[bugfix]-locale en-au: Sunday is changed as first day of week Issue #4349

@vigneshwar33 vigneshwar33 changed the title [bugfix]-locale en-au: Sunday is changed as first day of week [bugfix] locale en-au: Sunday is changed as first day of week Oct 19, 2019
@coveralls
Copy link

coveralls commented Oct 19, 2019 •
edited

Coverage Status

Coverage remained the same at 88.486% when pulling 1945f5b on vigneshwar33:develop into 04b275c on moment:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 88.336% when pulling 0b77cb6 on vigneshwar33:develop into 13a61b2 on moment:develop.

@ichernev ichernev changed the title [bugfix] locale en-au: Sunday is changed as first day of week [locale] en-au: Sunday is changed as first day of week Apr 23, 2020
@ichernev
Copy link
Contributor

@jarcoal what do you think?
@vigneshwar33 can you proof that this change is indeed correct (official source of first-day-of-week)?

@marwahaha
Copy link
Member

See #4349

@marwahaha
Copy link
Member

https://github.com/unicode-cldr/cldr-core/blob/36.0.0/supplemental/weekData.json#L72

@marwahaha marwahaha merged commit e3baef9 into moment:develop May 19, 2020
@jmattsson
Copy link

As an Aussie, this change completely threw me (and the system relying on this package). I am not aware of any business which considers Sunday to be the start of the week down here.

@jmattsson
Copy link

Also, I believe "AS ISO 8601-2007" specifies that Monday is officially the start of the week down here. See e.g. https://www.standards.org.au/standards-catalogue/sa-snz/communication/it-027/as--iso--8601-2007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vigneshwar33 @coveralls @ichernev @marwahaha @jmattsson