New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pt-BR localization - month names should not be capitalized #5109
Comments
Hello kendramae can I work on this issue? |
It depends on the situation. Here in Brasil we need to capitalize when it is an proper noun. Common example: "I was born in January": CORRECT: Eu nasci em janeiro. Proper noun example: "September 11 attacks": We also need to capitalize when it is a single word or it is the first word of a phrase/sentence. |
Ainda bem que sei usar a pesquisa, porque já estava abrindo uma issue pra isso mesmo. Parece que o jeito é usar toLowerCase(). I'm glad I use the search, because I was already opening an issue for that. It seems like the way to use toLowerCase(). |
No, it not depends on the situation. 11 de Setembro is not a date, is a historical fact. We need to capitalize only when the month starts in the beginning of phrase. Correct: Iniciou em 01 de janeiro. Correct: Janeiro foi o dia da viagem. |
moment should provide the default case as per the locale rule (lower case for pt-BR), and if you have a special case to handle (start of sentence), it's no longer the responsibility of moment (does not depends on the locale most of the time and never depends on the date itself) so it should be handled afterward: See google/closure-library: |
Month names should not be capitalized in Portuguese (See: https://meta.wikimedia.org/wiki/Capitalization_of_Wiktionary_pages#Capitalization_of_month_names) It looks like it originally was correct, but then was changed? (See: #4557) -- it may be as simple as reverting that commit.
The text was updated successfully, but these errors were encountered: