Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript missing isoWeeks for add/substract #5007

Closed
Klemensas opened this issue Feb 18, 2019 · 3 comments · Fixed by #5008
Closed

TypeScript missing isoWeeks for add/substract #5007

Klemensas opened this issue Feb 18, 2019 · 3 comments · Fixed by #5008

Comments

@Klemensas
Copy link
Contributor

Describe the bug
As a result of #4518 we can use isoWeek values in add/subtract. But TS typings weren't updated to allow for such usage.

Expected behavior
No error.

Screenshots
If applicable, add screenshots to help explain your problem.

Moment-specific environment
TypeScript
@Klemensas Klemensas changed the title Typescript missing isoWeeks for add/substract TypeScript missing isoWeeks for add/substract Feb 18, 2019
Klemensas added a commit to Klemensas/moment that referenced this issue Feb 18, 2019
@Klemensas
fix moment#5007: add ts isoWeek support
cb6b764
@Klemensas Klemensas mentioned this issue Feb 18, 2019
Merged
@LoganDupont
Copy link

I have the same problem. @icambron, @marwahaha can someone of you confirm this is an issue?

@njifares
Copy link

Any updates on this?

jwarykowski added a commit to jwarykowski/moment that referenced this issue Sep 4, 2019
@jwarykowski
Hotfix - Enable isoWeek when using add/subtract functions
6ba05fe 
If you use `isoWeek` within the add or subtract functions you get the following type error reported: 

```
Argument of type 'number' is not assignable to parameter of type 'DurationConstructor'.
```

Adding _isoWeek as valid type for DurationConstructor to fix this problem. This was original raised within moment#5007.
@jwarykowski jwarykowski mentioned this issue Sep 4, 2019
Closed
@Klemensas
Copy link
Contributor Author

I've made a PR for this the same day I opened the issue. Looks like no one cares enough to review it 🤷‍♂

ichernev pushed a commit that referenced this issue Apr 24, 2020
@Klemensas
[bugfix] ts: Add isoWeek option for duration constructor (fix #5007) (#…
c39c646 
…5008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bugfix] ts: add ts isoWeek support #5007 Klemensas/moment
3 participants
@njifares @LoganDupont @Klemensas