Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first week of 2019 issue #4833

Closed
elsafy opened this issue Oct 24, 2018 · 3 comments
Closed

first week of 2019 issue #4833

elsafy opened this issue Oct 24, 2018 · 3 comments

Comments

@elsafy
Copy link

elsafy commented Oct 24, 2018

Description of the Issue and Steps to Reproduce:
There is an issue which only happens for the first week of 2019, because it starts on 31 Dec 2018, please check the code below to reproduce
Environment:

Chrome 69 on OSX

const week = "2019-W01";
const weekResult = moment(week).format(moment.HTML5_FMT.WEEK);
console.log(weekResult);
// expected result: 2019-W01
// actual result: 2018-W01
@marwahaha
Copy link
Member

@ashsearle does #4700 address this?

@elsafy
Copy link
Author

elsafy commented Oct 24, 2018

@marwahaha yep definitely, thanks a lot for the hint

@ashsearle
Copy link
Contributor

@marwahaha Yes. I don't know why that PR failed to go green, but I'll happily do the close/re-open dance to get a green light once your PR fixing the build is merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants