Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[locale] tr: Add meridiem support #4701

Merged
merged 6 commits into from May 19, 2020
Merged

[locale] tr: Add meridiem support #4701

merged 6 commits into from May 19, 2020

Conversation

Zindev
Copy link
Contributor

@Zindev Zindev commented Jul 14, 2018

Meridem is not transalted to turkish.

@jsf-clabot
Copy link

jsf-clabot commented Jul 14, 2018 •
edited

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ marwahaha
❌ Zindev

@coveralls
Copy link

coveralls commented Jul 14, 2018 •
edited

Coverage Status

Coverage increased (+0.0009%) to 88.487% when pulling b698161 on Zindev:patch-1 into e3baef9 on moment:develop.

@marwahaha
Copy link
Member

@Zindev please edit the src/locale/tr.js file.

@marwahaha
Copy link
Member

@erhangundogan @BYK approval?

BYK
BYK approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ichernev
Copy link
Contributor

@Zindev you'll need to change the correct files src/locale/tr.js and src/test/locale/tr.js (and add tests for meridiem). Also you'd need to add isPM and meridiemParse, so it can be parsed, as well as formatted.

@ichernev ichernev changed the title Add meridem to tr.js [locale] tr: Add meridem support Apr 27, 2020
@ichernev ichernev changed the title [locale] tr: Add meridem support [locale] tr: Add meridiem support Apr 27, 2020
@marwahaha marwahaha merged commit 22bf4ca into moment:develop May 19, 2020
@marwahaha marwahaha removed the todo label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BYK BYK BYK approved these changes

@erhangundogan erhangundogan erhangundogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Zindev @jsf-clabot @coveralls @marwahaha @ichernev @BYK @erhangundogan