Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix #4698: Use ISO WeekYear for HTML5_FMT.WEEK #4700

Merged
merged 2 commits into from Dec 13, 2018
Merged

[bugfix] Fix #4698: Use ISO WeekYear for HTML5_FMT.WEEK #4700

merged 2 commits into from Dec 13, 2018

Conversation

ashsearle
Copy link
Contributor

@ashsearle ashsearle commented Jul 13, 2018 •
edited by marwahaha

Use the ISO WeekYear GGGG in HTML5_FMT.WEEK constant.

Updated test cases for the formatting constants to use a date/time that fails with the old YYYY format, to prevent regressions.

Fixes #4698
Fixes #4833

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 94.563% when pulling 10a98e3 on ashsearle:fix/4698 into 2e2a5b3 on moment:develop.

@coveralls
Copy link

coveralls commented Jul 13, 2018 •
edited

Coverage Status

Coverage increased (+0.0007%) to 88.136% when pulling 3fa1520 on ashsearle:fix/4698 into c68b4f1 on moment:develop.

@marwahaha marwahaha mentioned this pull request Oct 24, 2018
Closed
@marwahaha
Copy link
Member

Looks great. can we add the additional test cases from #4833 and #4698 into this PR?

I think if you merge/rebase from develop your updated Travis builds will pass the tests. :)

@marwahaha marwahaha merged commit 3147fbc into moment:develop Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashsearle @coveralls @marwahaha