Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] gu: Improve past relativeTime #4697

Merged
merged 3 commits into from Jun 17, 2020
Merged

Conversation

kartikm
Copy link
Contributor

@kartikm kartikm commented Jul 11, 2018

પેહલા-> પહેલા.

@jsf-clabot
Copy link

jsf-clabot commented Jul 11, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jul 11, 2018

Coverage Status

Coverage decreased (-0.03%) to 88.497% when pulling d99d1c8 on kartikm:patch-1 into 528ac2b on moment:develop.

@kartikm
Copy link
Contributor Author

kartikm commented Jul 18, 2018

Anything else to do from my side here?

@kartikm
Copy link
Contributor Author

kartikm commented Nov 28, 2018

Bump. What's missing in this pull request?

@marwahaha
Copy link
Member

@kartikm your tests are failing.
Thanks for opening this request.

Please only edit src/locale/gu.js and the tests in src/test/locale/gu.js.

Thoughts @Kaushik1987 ?

@ichernev
Copy link
Contributor

@kartikm it's kind of hard for me to manage this patch when I don't even see the characters ... can you provide some source for this change (CLDR for example)? Also you need to change the right files as @marwahaha mentioned.

@ichernev ichernev changed the title Fixed past relativeTime for gu [locale] gu: Improve past relativeTime Apr 27, 2020
@marwahaha
Copy link
Member

Thoughts @Kaushik1987

@Kaushik1987
Copy link
Contributor

@marwahaha What can i help ? Sorry for late reply.

@marwahaha
Copy link
Member

@Kaushik1987 - is this the correct change? Can you please review it.

@marwahaha marwahaha merged commit e1a969c into moment:develop Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants