New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[locale] fo: Fixed relativeTimes for m and M (#4609) #4682
[locale] fo: Fixed relativeTimes for m and M (#4609) #4682
Conversation
It appears that the original author is inactive on GitHub. Is there any fallback for this case? |
@sakarisson - we don't have a formal process, but maybe these will work:
|
@marwahaha - Thanks for the response.
|
26b206c
to
06517fc
Compare
src/locale/fo.js
Outdated
@@ -1,6 +1,6 @@ | |||
//! moment.js locale configuration | |||
//! locale : Faroese [fo] | |||
//! author : Ragnar Johannesen : https://github.com/ragnar123 | |||
//! author : Ragnar Johannesen, Kristian Sakarisson : https://github.com/ragnar123, https://github.com/sakarisson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I would prefer your name on a new line, like
https://github.com/moment/moment/blob/develop/src/locale/ro.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, simple change and I will merge it.
06517fc
to
f0f1b88
Compare
Fixed relativeTimes issues described in issue #4609.