Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] fo: Fixed relativeTimes for m and M (#4609) #4682

Merged
merged 3 commits into from Jan 21, 2019

Conversation

sakarisson
Copy link
Contributor

Fixed relativeTimes issues described in issue #4609.

@jsf-clabot
Copy link

jsf-clabot commented Jun 29, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jun 29, 2018

Coverage Status

Coverage remained the same at 88.404% when pulling f0f1b88 on Sakarisson:FO-RELATIVE-TIME-FIX-4609 into 24e55df on moment:develop.

@sakarisson
Copy link
Contributor Author

@ichernev
@ragnar123

@sakarisson
Copy link
Contributor Author

It appears that the original author is inactive on GitHub. Is there any fallback for this case?

@marwahaha
Copy link
Member

@sakarisson - we don't have a formal process, but maybe these will work:

  1. can you find other sources that confirm your change?
  2. can you join on as a "locale author"? please add your github name to the file.

@sakarisson
Copy link
Contributor Author

@marwahaha - Thanks for the response.

  1. What kind of sources are you thinking about? I linked to an online dictionary in my issue. I can probably also contact some source at the university to verify the translation.
  2. Will do.

@sakarisson sakarisson force-pushed the FO-RELATIVE-TIME-FIX-4609 branch 3 times, most recently from 26b206c to 06517fc Compare January 18, 2019 08:27
src/locale/fo.js Outdated
@@ -1,6 +1,6 @@
//! moment.js locale configuration
//! locale : Faroese [fo]
//! author : Ragnar Johannesen : https://github.com/ragnar123
//! author : Ragnar Johannesen, Kristian Sakarisson : https://github.com/ragnar123, https://github.com/sakarisson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I would prefer your name on a new line, like
https://github.com/moment/moment/blob/develop/src/locale/ro.js

Copy link
Member

@marwahaha marwahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, simple change and I will merge it.

@marwahaha marwahaha merged commit 38a19a7 into moment:develop Jan 21, 2019
@sakarisson sakarisson deleted the FO-RELATIVE-TIME-FIX-4609 branch January 22, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants