Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] it: Improve future relative time #4617

Merged
merged 2 commits into from Jun 18, 2020
Merged

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 7, 2018

I don't know Italian, but this is what my colleague said:

In Italian, "in" followed by a time expression is translated with "tra", not with "in".
There's no difference between "in a day" and "in 1 day" if they are both referred to future plans, they should both be translated with "tra" in Italian.
"In" in Italian refers to locations. It can also refer to time expressions, but not in the future.

The current translation is indeed a mistake and it should be changed to

tra un giorno

See more info about the use of "in" and "tra" in Italian here (not a complete grammar, of course, but it can give you the idea):
http://www.italianlanguageguide.com/grammar/prepositions/

@jsf-clabot
Copy link

jsf-clabot commented May 7, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented May 7, 2018

Coverage Status

Coverage increased (+0.006%) to 88.486% when pulling b99c8f2 on atscott:develop into 78fa472 on moment:develop.

@atscott
Copy link
Contributor Author

atscott commented May 7, 2018

@ichernev for locale approval

@marwahaha
Copy link
Member

@aliem thoughts ?

@ichernev
Copy link
Contributor

@atscott I don't know Italian, so when proposing locale changes you have to ping the original author, or provide a decent source of proof for your claim.

@aliem @nostalgiaz what do you think?

@ichernev
Copy link
Contributor

@atscott also this PR has a bunch of crap -- can you only commit the locale file + it's test.

@ichernev ichernev changed the title Update future relative time for Italian [locale] it: Improve future relative time Apr 27, 2020
@marwahaha
Copy link
Member

@nostalgiaz thoughts?

@marwahaha marwahaha changed the title [locale] it: Improve future relative time [locale] it: Improve future relative tim May 19, 2020
@marwahaha marwahaha changed the title [locale] it: Improve future relative tim [locale] it: Improve future relative time May 19, 2020
@marwahaha marwahaha closed this May 19, 2020
@marwahaha marwahaha reopened this May 19, 2020
@marwahaha
Copy link
Member

I would be comfortable merging this if someone else who speaks Italian can verify and join as a language author, or someone can find a source for this preference.

@marwahaha
Copy link
Member

@Manfre98 could you review this?

@marwahaha
Copy link
Member

I received this advice from a friend:

Hi Kunal, when using ''in'' you would mean a time length, as in ''I can run a marathon in 4 hours''. While using ''tra'' would mean like when something would happen, like as in ''we expect the game to start in 5 minutes''.

I think tra is the correct use here.

@marwahaha marwahaha merged commit 194e64d into moment:develop Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants