Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] fo: relativeTime is incorrect #4609

Closed
sakarisson opened this issue May 4, 2018 · 2 comments
Closed

[locale] fo: relativeTime is incorrect #4609

sakarisson opened this issue May 4, 2018 · 2 comments

Comments

@sakarisson
Copy link
Contributor

sakarisson commented May 4, 2018

Description of bug
The "one minute" and "one month" values in the Faroese locale are wrong.

In both cases, the word should be in singular indefinite nominative form.

At the moment, the value for minute is in accusative form (minutt) and month is in dative form (mánaði).

A free Faroese dictionary can be found here: Sprotin.fo

In /locale/fo.js, the relativeTime object should be changed as follows:

relativeTime: {
  m : 'ein minuttur',
  M : 'ein mánaður',
}

Steps to reproduce bug:
Create moment instance with the locale 'fo' and call fromNow() when the time difference is either one minute or one month.

@ichernev
Copy link
Contributor

@ragnar123 what do you think?
@sakarisson can you make a PR in the mean time?

@ichernev ichernev changed the title Faroese (fo) locale relativeTimes incorrect [locale] fo: relativeTime is incorrect Jun 27, 2018
@sakarisson
Copy link
Contributor Author

sakarisson commented Jun 29, 2018

@ichernev I can create a PR. I'll tag you in it if it's okay.

sakarisson added a commit to sakarisson/moment that referenced this issue Jun 29, 2018
sakarisson added a commit to sakarisson/moment that referenced this issue Jan 18, 2019
marwahaha pushed a commit that referenced this issue Jan 21, 2019
* [locale] fo: Fixed relativeTimes for m and M (#4609)

* Add new Faroese locale author

* Revert locale/* edit from commit b51d421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants