Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[locale] Capitalization of pt month names #4557

Merged
merged 5 commits into from Jan 19, 2019
Merged

[locale] Capitalization of pt month names #4557

merged 5 commits into from Jan 19, 2019

Conversation

cassmtnr
Copy link
Contributor

No description provided.

@cassmtnr
Copy link
Contributor Author

cassmtnr commented Apr 13, 2018 •
edited

@marwahaha @mj1856 How do I check what is failing?

@mercutiodesign
Copy link
Contributor

You can either run the tests locally using grunt test or look at the travis log. So in your case it seems to be Test: format.

@cassmtnr cassmtnr closed this Apr 13, 2018
@cassmtnr cassmtnr deleted the patch-4 branch April 13, 2018 16:49
@cassmtnr cassmtnr restored the patch-4 branch April 13, 2018 16:54
@cassmtnr cassmtnr reopened this Apr 13, 2018
@cassmtnr cassmtnr changed the title [locale] Capitalization of pt-br month names [locale] Capitalization of pt month names Apr 13, 2018
@cassmtnr
Copy link
Contributor Author

cassmtnr commented Apr 13, 2018 •
edited

I had made multiple pull requests about the same subject by mistake, so I corrected this one for PT language only, the other one is for PT-BR (#4558), and 3 duplicates are closed (#4556, #4555 and
#4554).

@cassmtnr cassmtnr mentioned this pull request Apr 13, 2018
Merged
@coveralls
Copy link

coveralls commented Apr 13, 2018 •
edited

Coverage Status

Coverage increased (+0.02%) to 94.647% when pulling 4e555eb on cassianomon:patch-4 into 10013b1 on moment:develop.

@marwahaha
Copy link
Member

@caio-ribeiro-pereira thoughts ?

@caio-ribeiro-pereira
Copy link
Contributor

@marwahaha everything is okay for me :)

@cassmtnr
Copy link
Contributor Author

@marwahaha when this is gonna be released?

@marwahaha marwahaha merged commit 91550f8 into moment:develop Jan 19, 2019
@marwahaha marwahaha mentioned this pull request Jan 19, 2019
Closed
@kendramae kendramae mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caio-ribeiro-pereira caio-ribeiro-pereira caio-ribeiro-pereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cassmtnr @mercutiodesign @coveralls @marwahaha @caio-ribeiro-pereira