-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[locale] Fix wrong calendar() output in 'be' localisation #4528
Conversation
@Oire any thoughts ? |
As a native speaker, I can confirm that's correct. |
@DmitryScaletta are there any cases of using |
@DmitryScaletta @SobakaSlava shall I merge this? |
@marwahaha Yes, sure |
@SobakaSlava - can you add a test? |
@marwahaha actually it seems like the tests are already done for this case |
@SobakaSlava - to prevent this issue in the future, it'd be great to check in an additional test of the exact issue you have, to ensure that this change is what you want. |
Ok, I tried pushing to your branch but I didn't have access. Please add the following to src/test/locale/be.js:
This was the old behavior, which I assume is unexpected.
|
@marwahaha sorry for a long wait. I've added the test. |
Thanks for improvement! Excuse me for being not available during the conversation. |
@marwahaha Ready to review |
fixes #4502
@demidov91, there was wrong regexp (I assume
be
localisation was copied fromru
andВв
was not changed byУу
) and that caused wrong output of calendar() function (Неправильно брались падежи)