Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Update downloads badge to point to graph of downloads 馃搱 #4463

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

cheapsteak
Copy link
Contributor

馃憢馃槂

Noticed that your "npm" badge and "downloads" badge currently both point to the same page on npmjs.org

I was wondering if you might prefer having the download badge point to a download chart instead?

If not, feel free to close and apologies for the drive-by PR 馃槃

@jsf-clabot
Copy link

jsf-clabot commented Mar 2, 2018

CLA assistant check
All committers have signed the CLA.

@cheapsteak cheapsteak changed the title Update downloads badge to point to graph of downloads Update downloads badge to point to graph of downloads 馃搱 Mar 2, 2018
@cheapsteak cheapsteak changed the title Update downloads badge to point to graph of downloads 馃搱 [misc] Update downloads badge to point to graph of downloads 馃搱 Mar 2, 2018
@marwahaha
Copy link
Member

This seems cool! Few quick questions:

  1. Are you related to npmcharts.com ? Are they a private entity? Associated with https://www.npmjs.com/ ?
  2. Is this used on other large open-source projects?

@cheapsteak
Copy link
Contributor Author

cheapsteak commented Mar 4, 2018

Thanks! It's been an open source project of mine for the past ~4 years, not affiliated with npmjs.com. Repo here - https://github.com/cheapsteak/npmcharts.com

It's currently linked to in the readmes of webpack, gatsby, redux-form, downshift, antd, commander.js, and PM2 (on the development branch) :)

@marwahaha
Copy link
Member

Cool, thanks!

@marwahaha marwahaha merged commit b31ff9d into moment:develop Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants