Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] Fix zh-tw locale #4430

Merged
merged 1 commit into from
Mar 5, 2018
Merged

[locale] Fix zh-tw locale #4430

merged 1 commit into from
Mar 5, 2018

Conversation

ayhaadam
Copy link
Contributor

@ayhaadam ayhaadam commented Feb 1, 2018

Properly add spaces between CJK characters and alphanumeric characters in calendar time format.

For @ben-lin and @hehachris
此修改在 Calendar Time 顯示中,在中文字與英數字適當加入空格
「下星期一12:00」->「下星期一 12:00」
「今天13:00」->「昨天 13:00」
像是日文 locale 也是相同的格式用法

排版標準:https://github.com/sparanoid/chinese-copywriting-guidelines

舉例來說 Facebook 也是如此顯示

Properly add spaces between CJK characters and alphanumerics character and in calendar time format.
@marwahaha
Copy link
Member

@ben-lin thoughts?

@ben-lin
Copy link
Contributor

ben-lin commented Mar 5, 2018

It might be late but looks good to me.

@marwahaha marwahaha merged commit bb41a7c into moment:develop Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants