[bugfix] isBetween should return false for invalid dates #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashsearle
changed the title
ashsearle
changed the title
marwahaha
requested changes
Apr 16, 2018
| @@ -226,7 +226,7 @@ test('is between year', function (assert) { | |||
| assert.equal(m.isBetween( | |||
| moment(new Date(2010, 5, 6, 7, 8, 9, 10)), | |||
| moment(new Date(2011, 5, 6, 7, 8, 9, 10)), 'year'), false, 'year is later'); | |||
| assert.equal(m.isBetween(m, 'year'), false, 'same moments are not between the same year'); | |||
| assert.equal(m.isBetween(m, m, 'year'), false, 'same moments are not between the same year'); | |||
| assert.equal(+m, +mCopy, 'isBetween millisecond should not change moment'); | ||
| }); | ||
|
|
||
| test('is between invalid', function (assert) { |
There was a problem hiding this comment.
Can we add a case to show that inclusivity flags don't affect this?
For example, #4416 was only an issue with the flags set to '[]'
There was a problem hiding this comment.
OK, tests added for all inclusivity flag combos
|
@ashsearle thanks a lot! Very well done! |
marwahaha
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
isBetweento fix a couple of issues from #4416 and #4114 .Documentation states that
invalid.isBetween(another, another)should returnfalse, but #4416 highlights a case where it doesn't. This PR fixes #4416 and ensuresisBetween(..)returnfalseno matter what unit or inclusivity flags are used:The conversation in #4114 highlights some examples that are incompatible with current typescript bindings. This PR fixes the typescript binding to match example code - explicitly allowing
nullto be passed in as theunitsvalue, - and this now follows a faster code path to avoid cloning moments unnecessarily - i.e. fixes #4114.