Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix for ReDOS vulnerability (see #4163) #4326

Merged
merged 3 commits into from Nov 29, 2017

Conversation

migg24
Copy link
Contributor

@migg24 migg24 commented Nov 28, 2017

Limiting regex match to 256 chars, fixing #4163.

I did not change the minified versions because I assumed that would be part of some build process and could not find anything about it in "contributing". Please advise if this has to be done manually somehow.

@jsf-clabot
Copy link

jsf-clabot commented Nov 28, 2017

CLA assistant check
All committers have signed the CLA.

@migg24 migg24 changed the title Fix for ReDOS vulnerability [bugfix] Fix for ReDOS vulnerability Nov 28, 2017
@icambron
Copy link
Member

This seems reasonable to me. @ichernev / @marwahaha can we get this one in?

@marwahaha marwahaha changed the title [bugfix] Fix for ReDOS vulnerability [bugfix] Fix for ReDOS vulnerability (see #4163) Nov 29, 2017
@marwahaha marwahaha merged commit 69ed9d4 into moment:develop Nov 29, 2017
@migg24
Copy link
Contributor Author

migg24 commented Nov 29, 2017

Thx for merging!

cerinman added a commit to mxenabled/mx-react-components that referenced this pull request Aug 6, 2018
cerinman added a commit to mxenabled/mx-react-components that referenced this pull request Aug 7, 2018
* Update moment to fix vulnerability

moment/moment#4326

* unlock moment

The bug that caused us to lock it down has been resolved.

moment/moment#4216
justbill2020 added a commit to justbill2020/moment-timer that referenced this pull request Feb 8, 2021
- corrects advisories 55 & 532

moment/moment#4163
moment/moment#4326

Update package.json and readme with this repo.
justbill2020 added a commit to justbill2020/moment-timer that referenced this pull request Feb 19, 2021
- corrects security advisories 55 & 532

moment/moment#4163
moment/moment#4326

Update package.json and readme.
justbill2020 added a commit to justbill2020/moment-timer that referenced this pull request Feb 19, 2021
- updated moment.js version in vendor folder
- added r.js (require.js)
- created nodejs example

Minor version bump, Security fix

- corrects security advisories 55 & 532

moment/moment#4163
moment/moment#4326

Update package.json and readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants