Daylight saving time issue

[darakeon]

The function endOf of 2017-10-15 returns a value greater than startOf of 2017-10-16

• GMT-3h, Brazil
• Chrome, Firefox and Edge - Windows 10
• Chrome - Arch Linux
• version 2.18.1

The code we've done as fix:

    let endOf = dates.clone().endOf('day')

    const startOfDayAfter =
      dates.clone().add(1, 'days').startOf('day')

    if (startOfDayAfter.isBefore(endOf)) {
      endOf = startOfDayAfter.add(-1, 'milliseconds')
    }

[derekstavis]

This issue was originally found on react-dates/react-dates/issues/776

[icambron]

Yeah, this is an old bug and it's particularly acute in Brazil because of the midnight DST. See e.g. #1990, #4164, #2749, and most importantly #3132

[darakeon]

@icambron, after opening the issue I looked into the code and fixed it: #4254