Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] pt: Fix capital letters in weekdays #3989

Merged
merged 6 commits into from
Apr 11, 2018
Merged

Conversation

horus68
Copy link
Contributor

@horus68 horus68 commented May 31, 2017

In Portuguese (Portugal) weekdays are in lowercase. So its required that working days will be like Segunda-feira not as the actual value Segunda-Feira

For those on grammar:
Even the first capital letter is only Ok when in a single word or the first word in a sentence. Regular usage (in the middle of a sentence) it would be all in lowercase.
But we can't control here when it will show one way or the other, so the initial capital letter!

Reference: https://ciberduvidas.iscte-iul.pt/consultorio/perguntas/meses-e-dias-da-semana-outra-vez/3743

In Portuguese (Portugal) weekdays can only have one capital letter. So its Segunda-feira not Segunda-Feira
@jsf-clabot
Copy link

jsf-clabot commented May 31, 2017

CLA assistant check
All committers have signed the CLA.

@ichernev
Copy link
Contributor

ichernev commented Aug 3, 2017

@jalex79 what do you think

@horus68 you need to update tests in src/test/locale/pt.js.

@ichernev ichernev changed the title Typo fixing capital letter for weekedays [locale] pt: Fix capital letters in weekdays Aug 3, 2017
pt: Fix capital letters in weekdays
@horus68
Copy link
Contributor Author

horus68 commented Aug 3, 2017

@ichernev done

@marwahaha marwahaha changed the title [locale] pt: Fix capital letters in weekdays [local] pt: Fix capital letters in weekdays Dec 11, 2017
@marwahaha marwahaha changed the title [local] pt: Fix capital letters in weekdays [locale] pt: Fix capital letters in weekdays Dec 11, 2017
@marwahaha
Copy link
Member

@horus68 - there's a small conflict - could you resolve it?

@horus68
Copy link
Contributor Author

horus68 commented Dec 11, 2017

@marwahaha I tried to fix the conflict but now Travis failed.
I don't have the knowledge to fix this!

Note: "Allow edits from maintainers" its active if you have the time

@marwahaha
Copy link
Member

marwahaha commented Dec 14, 2017

I made a change @horus68 - it looked like one test got adjusted. A few thoughts:

  • do we have confirmation from @jalex79 ?
  • should all months be lowercase, also?
  • should Saturday and Sunday be lowercased?

@jalex79
Copy link
Contributor

jalex79 commented Dec 15, 2017

In the middle of a sentence, the names of the days of the week are in lower case (domingo, segunda-feira, ..., sábado). But in bonds, and obviousness, at the beginning of sentences, is capitalized. The same thing to the names of the months.

@marwahaha
Copy link
Member

Ok, great.

@horus68 / @jalex79 , last question:

@marwahaha
Copy link
Member

Ok, I will merge it as is.

@marwahaha marwahaha merged commit 10013b1 into moment:develop Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants