Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Add coveralls testing to travis build #3848

Merged
merged 2 commits into from
Apr 9, 2018

Conversation

marwahaha
Copy link
Member

@marwahaha marwahaha commented Mar 18, 2017

I think this will just work. Check out my own Travis Builds and Coveralls here:
https://travis-ci.org/marwahaha/moment/builds
Coverage Status

Builds are significantly longer (takes ~4 minutes instead of ~3), but the coverage is probably worth it. I sort of prefer long builds to flaky/less-useful builds. (This is why I decided to test twice --- once with default and once with coveralls)

this is moment develop's, but it might be out of date
Coverage Status

fixes #2509

@coveralls
Copy link

coveralls commented Mar 18, 2017

Coverage Status

Changes Unknown when pulling 17a26b2 on marwahaha:add-coveralls into ** on moment:develop**.

@marwahaha
Copy link
Member Author

@ichernev

@ichernev
Copy link
Contributor

ichernev commented Aug 3, 2017

Looks good to me. If its only on travis I'm fine.

@ichernev ichernev changed the title Add coveralls testing to travis build [misc] Add coveralls testing to travis build Aug 3, 2017
@ichernev
Copy link
Contributor

ichernev commented Aug 6, 2017

Merged in 7c3d1ea

@ichernev ichernev closed this Aug 6, 2017
ichernev added a commit that referenced this pull request Aug 6, 2017
[misc] Add coveralls testing to travis build
ichernev added a commit that referenced this pull request Aug 7, 2017
This reverts commit 7c3d1ea, reversing
changes made to 759b4a4.
@ichernev
Copy link
Contributor

ichernev commented Aug 7, 2017

I had to revert this 619d0d2, the build was very flaky, especially on older node versions. We can put this back in after we figure out what is causing it, in the mean time I want travis builds to be green (while I'm preparing the next release).

@ichernev ichernev reopened this Aug 7, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 17a26b2 on marwahaha:add-coveralls into ** on moment:develop**.

@ichernev
Copy link
Contributor

ichernev commented Aug 9, 2017

@marwahaha can you please investigate?

@icambron icambron added the todo label Oct 9, 2017
@icambron
Copy link
Member

icambron commented Oct 9, 2017

One option is to eliminate older Node versions from the CI

fbonzon pushed a commit to fbonzon/moment that referenced this pull request Oct 28, 2017
@coveralls
Copy link

coveralls commented Nov 19, 2017

Coverage Status

Changes Unknown when pulling 6c4c7a7 on marwahaha:add-coveralls into ** on moment:develop**.

@marwahaha
Copy link
Member Author

@ichernev I think increasing the wait time for qunit (changed from 2min to 10min) has fixed the circle builds:
https://travis-ci.org/moment/moment/builds/304282118

I restarted it and it succeeded again.

@marwahaha marwahaha removed the todo label Nov 20, 2017
@marwahaha marwahaha changed the title [misc] Add coveralls testing to travis build x[misc] Add coveralls testing to travis build Dec 19, 2017
@marwahaha marwahaha changed the title x[misc] Add coveralls testing to travis build [misc] Add coveralls testing to travis build Dec 19, 2017
@marwahaha marwahaha changed the title [misc] Add coveralls testing to travis build x[misc] Add coveralls testing to travis build Dec 19, 2017
@marwahaha marwahaha changed the title x[misc] Add coveralls testing to travis build [misc] Add coveralls testing to travis build Dec 19, 2017
@marwahaha marwahaha changed the title [misc] Add coveralls testing to travis build x[misc] Add coveralls testing to travis build Dec 19, 2017
@marwahaha marwahaha changed the title x[misc] Add coveralls testing to travis build [misc] Add coveralls testing to travis build Dec 19, 2017
@marwahaha marwahaha merged commit 9ddfeb5 into moment:develop Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coveralls.io reporting doesn't work
4 participants