-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] Add coveralls testing to travis build #3848
Conversation
Changes Unknown when pulling 17a26b2 on marwahaha:add-coveralls into ** on moment:develop**. |
Looks good to me. If its only on travis I'm fine. |
Merged in 7c3d1ea |
[misc] Add coveralls testing to travis build
I had to revert this 619d0d2, the build was very flaky, especially on older node versions. We can put this back in after we figure out what is causing it, in the mean time I want travis builds to be green (while I'm preparing the next release). |
Changes Unknown when pulling 17a26b2 on marwahaha:add-coveralls into ** on moment:develop**. |
@marwahaha can you please investigate? |
One option is to eliminate older Node versions from the CI |
Changes Unknown when pulling 6c4c7a7 on marwahaha:add-coveralls into ** on moment:develop**. |
@ichernev I think increasing the wait time for qunit (changed from 2min to 10min) has fixed the circle builds: I restarted it and it succeeded again. |
I think this will just work. Check out my own Travis Builds and Coveralls here:
https://travis-ci.org/marwahaha/moment/builds
Builds are significantly longer (takes ~4 minutes instead of ~3), but the coverage is probably worth it. I sort of prefer long builds to flaky/less-useful builds. (This is why I decided to test twice --- once with
default
and once with coveralls)this is moment develop's, but it might be out of date
fixes #2509