[feature] Ignore NaN values in setters #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is is as simply not catching being a falsy (but assumedly valid) time zone modifier (_tzm?) of 0
…input is a valid value
|
Unless I' missing something you can remove isNumber impl and tests, as it is not used. Looks good, we should make the moment invalid on invalid set for v3. |
|
@ichernev - Will remove and update PR. Will also rebase. |
wi-ski
changed the title
|
@wi-ski you haven't signed the CLA, so can't really merge this yet. |
|
The check claims he has: |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Aug 6, 2017
[fixup] Drop isNumeric utility fn, fixes #3735
This was referenced Oct 11, 2017
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have issues with this approach - would like to discuss. Primary issue is that I could not get the previous tests passing with this implementation. Meaning, this implementation is intentionally gimped.