From fd14000ca42bb003c429f0ea96966f7b4b80951c Mon Sep 17 00:00:00 2001 From: Ash Searle Date: Mon, 16 Apr 2018 09:46:31 +0100 Subject: [PATCH] Add tests requested in code review --- src/test/moment/is_between.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/test/moment/is_between.js b/src/test/moment/is_between.js index 19f2b671f4..656112cc2d 100644 --- a/src/test/moment/is_between.js +++ b/src/test/moment/is_between.js @@ -362,6 +362,20 @@ test('is between invalid', function (assert) { validFrom = moment(new Date(2010, 1, 2, 3, 4, 5, 6)), validTo = moment(new Date(2012, 1, 2, 3, 4, 5, 6)); assert.equal(invalid.isBetween(validFrom, validTo), false, 'this instance invalid'); + assert.equal(invalid.isBetween(validFrom, validTo, '[]'), false, 'this instance invalid []'); + assert.equal(invalid.isBetween(validFrom, validTo, '[)'), false, 'this instance invalid [)'); + assert.equal(invalid.isBetween(validFrom, validTo, '(]'), false, 'this instance invalid (]'); + assert.equal(invalid.isBetween(validFrom, validTo, '()'), false, 'this instance invalid ()'); + assert.equal(valid.isBetween(invalid, validTo), false, 'from invalid moment'); + assert.equal(valid.isBetween(invalid, validTo, '[]'), false, 'from invalid moment []'); + assert.equal(valid.isBetween(invalid, validTo, '[)'), false, 'from invalid moment [)'); + assert.equal(valid.isBetween(invalid, validTo, '(]'), false, 'from invalid moment (]'); + assert.equal(valid.isBetween(invalid, validTo, '()'), false, 'from invalid moment ()'); + assert.equal(valid.isBetween(validFrom, invalid), false, 'to invalid moment'); + assert.equal(valid.isBetween(validFrom, invalid, '[]'), false, 'to invalid moment []'); + assert.equal(valid.isBetween(validFrom, invalid, '[)'), false, 'to invalid moment [)'); + assert.equal(valid.isBetween(validFrom, invalid, '(]'), false, 'to invalid moment (]'); + assert.equal(valid.isBetween(validFrom, invalid, '()'), false, 'to invalid moment ()'); });