Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-built bundles have data mismatch with data files #924

Closed
Etchelon opened this issue Jan 11, 2021 · 2 comments
Closed

Pre-built bundles have data mismatch with data files #924

Etchelon opened this issue Jan 11, 2021 · 2 comments

Comments

@Etchelon
Copy link

Etchelon commented Jan 11, 2021

Moment-timezone version which you use:

Version: 0.5.32 (latest right now)

Note: many issues are resolved if you just upgrade to the latest version

Issue description:

node_modules/moment-timezone/builds/moment-timezone-with-data.js

contains, for the "GL" country, the America/Godthab timezone, which has been deprecated, in fact all data files (metadata, unpacked and package latest) contain America/Nuuk instead (which has replaced Godthab).

I have seen that the entry point (index.js) loads the metadata files, but since the package.json tells bundlers to use builds/moment-timezone-with-data.js as the package's entry point, my Angular app contains the deprecated timezone hardcoded in the .js bundle.

Seems like a new version is needed with rebuilt bundles to fix the issue.

@gilmoreorless
Copy link
Member

This is most likely caused by an issue where the data compilation process loses information about which zones are links: #835

@ichernev
Copy link
Contributor

@Etchelon if you really want a slick data package without extra baggage package one yourself. The source data is pretty well documented, and the moment-timezone pipeline is not terrible either.

One thing to note is that we could actually link zones that are the same, instead of copy-pasting their DST points, but nobody has proposed that so far. If somebody implemented it and made a PR it could get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants