Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time is off by -1 hour on a 2099 date when switching from 0.5.25 to 0.5.27 #798

Closed
bdavis-tc opened this issue Nov 7, 2019 · 5 comments
Closed

Comments

@bdavis-tc
Copy link

Simplified reproduction code:
https://runkit.com/bdavis-tc/5dc43803b63326001b4f6f53

Dates after year 2037 the 0.5.27 version misses the time by an hour.
My test date is in the year 2099.
Testing against timezone: EST (with Daylight Savings Time)

The 0.5.25 version seems to have accurate time all the way to year 2499.

Not sure if the 0.5.26 and 0.5.27 version introduced a bug, or just changed default behavior for how much data to include.

For now we will stick with 0.5.25, looking to improve my understanding and/or implementation to allow us to use the latest version again.

Thank you!

@gilmoreorless
Copy link
Member

This is probably due to the (accidentally?) reduced data size due to a change in release process from 0.5.26 onwards (#768).

@micheleangioni
Copy link

Hi guys, I've lost around 3 hours today due to this :|
One of our test dates is 2060 and since v0.5.26 the offset of dates with Europe/Berlin timezone is wrong. It seems to be indeed related to (#768).

@andywu0408
Copy link

Following up on this - This problem still persists as of now for me.

@eramitmittal
Copy link

Please look at #921
Fork available at: https://github.com/eramitmittal/moment-timezone

@ichernev
Copy link
Contributor

Latest moment-timezone (0.5.37) has extended range. In the future we'll release on Linux :) check #999 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants