Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack bundle itself #770

Closed
hosseinalipour opened this issue Jul 12, 2019 · 2 comments
Closed

webpack bundle itself #770

hosseinalipour opened this issue Jul 12, 2019 · 2 comments
Labels
peer-dependencies

Comments

@hosseinalipour
Copy link

I don't know if the problem is with my Webpack configuration or the moment. but it only happens when I add moment-timezone(not moment) and suddenly webpack bundle itself as well, apart from horror stories I heard about moment bundle sizes ...
here's the screenshot
Screenshot (19)
@ellenaua
Copy link
Contributor

ellenaua commented Sep 7, 2019

=( this is because we need to move moment to "peerDependencies" otherwise you have 2 moment-s installed

@ichernev
Copy link
Contributor

Closing this in favor of #799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
peer-dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ichernev @hosseinalipour @ellenaua