New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: moment and moment-timezone don't play well together #370

Closed

sfrooster opened this issue Aug 1, 2016 · 1 comment

Labels

sfrooster commented Aug 1, 2016

Several things here:

moment-timezone doesn't have TS support like moment does (I see this is a separate issue)
current moment-timezone definitions don't include format()
current moment-timezone definitions fail compilation (MomentTimeZoneFormat is not defined)
momentTZ.tz() produces a Moment which is incompatible with moment() (Operator '<=' cannot be applied to types 'Moment' and 'Moment'.)

mattjohnsonpint added the TypeScript label

cspotcode mentioned this issue

Yet another PR adding TypeScript declarations #530

Merged

Member

gilmoreorless commented Jan 28, 2023

I know this is an old issue, but for completeness:

Moment Timezone added type definitions in version 0.5.29.
Some type errors between moment() and moment.tz() are caused by multiple versions of the moment package in the dependency tree. See [Typescript] Moment types have been updated #982 (comment) for more explanation.

gilmoreorless closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment