Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated parsing tokens note #995

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Remove outdated parsing tokens note #995

merged 1 commit into from
Jul 25, 2021

Conversation

dasa
Copy link
Contributor

@dasa dasa commented Jul 22, 2021 •
edited

Removed:

That includes all the "macro" formats like "D" for "localized numeric date".

D is in the table and is working, so I assume this is outdated.

luxon.DateTime.fromFormat("22/07/2021", "D", { locale: "en-GB" }).toISO() -> "2021-07-22T00:00:00.000-07:00"

icambron
icambron approved these changes Jul 25, 2021
View reviewed changes
Copy link
Member

@icambron icambron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks

@icambron icambron merged commit 64ffd35 into moment:master Jul 25, 2021
@dasa dasa deleted the patch-2 branch August 2, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icambron icambron icambron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasa @icambron