docs(datetime): fix typo #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks good. Can you sign the CLA? |
@icambron The certificate on https://cla.js.foundation/moment/luxon?pullRequest=987 was revoked. Is there another way to proceed it? |
|
@blackwindforce meaning the SSL cert? Not seeing that from here. Can you double check? If it's still an issue, I'll I'll ask the JS foundation |
|
@icambron Yes, I've double checked. That's why I didn't sign CLA in the first place. Would you please contact JS foundation? Here's the report https://www.ssllabs.com/ssltest/analyze.html?d=cla.js.foundation, and my browser also blocks the site with NET::ERR_CERT_REVOKED. |
|
@icambron I've signed CLA, please review. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.