New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent error from being thrown in IANAZone.offset #906

Merged

icambron merged 1 commit into moment:master from gumgl:issue-905

May 8, 2021

Contributor

gumgl commented Mar 23, 2021

To fix bug #905.

I confirmed the fix in the browser (local build):

let d = luxon.DateTime.local();
let dz = d.setZone("America/Vancouver");

d.plus({seconds: 12345678901234567890});
DateTime {ts: 1.2345678902851053e+22, _zone: LocalZone, loc: Locale, invalid: Invalid, weekData: null, …}

dz.plus({seconds: 12345678901234567890});
DateTime {ts: 1.2345678902851053e+22, _zone: IANAZone, loc: Locale, invalid: Invalid, weekData: null, …}


          Prevent error from being thrown in IANAZone.offset

7e194a7

gumgl mentioned this pull request

Crash gumgl/milestones#11

Closed

icambron merged commit 34add62 into moment:master

louisbuchbinder commented Jun 22, 2021

Thank you for your work @gumgl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment