Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromSeconds: Update to user friendly error message #1525

Open
razzpoker50 opened this issue Oct 10, 2023 · 0 comments
Open

fromSeconds: Update to user friendly error message #1525

razzpoker50 opened this issue Oct 10, 2023 · 0 comments

Comments

@razzpoker50
Copy link

razzpoker50 commented Oct 10, 2023

Is your feature request related to a problem? Please describe.

When I was trying to get the timestamp in seconds DateTime.fromSeconds(modifiedDate) I am seeing the following error.

Uncaught Error: fromSeconds requires a numerical input

    at Function.fromSeconds (luxon.js:5344)

Describe the solution you'd like
It would be nice to have a better error message stating the type and the value that was passed in.
E.g.

throw new InvalidArgumentError(
        `fromSeconds requires a numerical input, but received a ${typeof seconds} with value ${seconds}`
      );

Describe alternatives you've considered
Additional guard checks in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant