Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs on react native android support #1367

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Update docs on react native android support #1367

merged 1 commit into from
Mar 4, 2023

Conversation

ramijarrar
Copy link
Contributor

Resurrecting #609 which was closed because the original author @roadmanfong didn't sign the CLA.

Have revised the wording, and simplified the diff for configuring jsc build flavor.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 26, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ramijarrar / name: Rami Jarrar (44f0afc)

@ramijarrar
Copy link
Contributor Author

ramijarrar commented Jan 26, 2023 •
edited

Updated to clarify Hermes is enabled by default on RN >=0.70 (which already supports Intl on Android and iOS).

@icambron
Copy link
Member

icambron commented Mar 4, 2023

Thanks!

@icambron icambron merged commit 304bddc into moment:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ramijarrar @icambron