Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort React prop types #4

Closed
amannn opened this issue Sep 14, 2017 · 1 comment · Fixed by #25
Closed

Sort React prop types #4

amannn opened this issue Sep 14, 2017 · 1 comment · Fixed by #25

Comments

@amannn
Copy link
Member

amannn commented Sep 14, 2017

Could be interesting to mirror the setting from react/jsx-sort-props. However this isn't helpful as long as issues reported by the rule can't be fixed automatically.
@amannn
Copy link
Member Author

amannn commented Jan 30, 2019

Update: react/sort-prop-types can now be fixed automatically 🎉. What's missing though, is moving leading comments together with the prop type. There's an open PR for this though which looks like it might make it to the codebase.

Enabling react/jsx-sort-default-props might be a good idea as well, however this rule is currently not auto-fixable. Also note that the rule might get renamed to react/sort-default-props.

@amannn amannn added the blocked label Jun 5, 2019
@amannn amannn removed the blocked label Jul 31, 2019
amannn added a commit that referenced this issue Jul 31, 2019
@amannn
- Resolves #4
a6b6e9a 
- Resolves #19
- Resolves #20
- Resolves #21
- Resolves #22
- Resolves #23
- Sort rules alphabetically
@amannn amannn mentioned this issue Jul 31, 2019
Merged
@amannn amannn closed this as completed in #25 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rules as mentioned in issues molindo/eslint-config-molindo
1 participant
@amannn