Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up cohort view general design into two sections: General design and Population and add some missing data items #3609

Closed
BrendaHijmans opened this issue Apr 5, 2024 · 3 comments · Fixed by #3760
Closed

Split up cohort view general design into two sections: General design and Population and add some missing data items #3609

BrendaHijmans opened this issue Apr 5, 2024 · 3 comments · Fixed by #3760
Assignees
@connoratrug
Labels
priority Features/bugs that we should not let wait ssr-catalogue ssr-pretest
Milestone
Sprint 221

Comments

@BrendaHijmans
Copy link
Contributor

BrendaHijmans commented Apr 5, 2024 •
edited

What version of EMX2 are you using (see footer)
v10.49.10

Describe the bug
Some data items for cohorts are not shown.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://emx2.dev.molgenis.org/catalogue-demo/ssr-catalogue/testNetwork1/cohorts/testCohort1
  2. Scroll down to section General design.
  3. The section can be subdivided into 2 sections as such:

“General design”, with fields:
Cohort type
Design
Design description
Design schematic
Collection type
Start/end year
Design paper
PID

"Population", with fields:
Countries (renamed from Population, does not cover the content)
Regions
Number of participants
Number of participants with samples
Population age groups
Main medical condition
ICDO site (Data resources.population oncology topology; ontology_array)
ICDO morphology (Data resources.population oncology morphology; ontology_array)
Inclusion criteria (Cohorts.inclusion criteria; ontology_array)
Other inclusion criteria (Cohorts.other inclusion criteria; text)

New fields in italics

image

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@connoratrug
Copy link
Contributor

This looks more like a feature request then an issue or bug, please consider using the feature request template or create a trac ticket. The feature requests template has several relevant questions; https://github.com/molgenis/molgenis-emx2/issues/new?assignees=&labels=&projects=&template=feature_request.md&title=

@esthervanenckevort esthervanenckevort added this to the Inbox milestone Apr 19, 2024
@esthervanenckevort esthervanenckevort modified the milestones: Inbox, Sprint 221 May 3, 2024
@EleanorHyde-UMCG EleanorHyde-UMCG added the priority Features/bugs that we should not let wait label May 7, 2024
@BrendaHijmans
Copy link
Contributor Author

I think moving this to a feature request just creates more work. Can't this just be seen as a feature request? The request text will not be changed by moving from a bug request to a feature request. In my opinion it can also be treated as a bug, because the items are not shown, but should be shown.

@mswertz
Copy link
Member

mswertz commented May 16, 2024

I think Connor simply asks to check the standard feature request questions:

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

connoratrug added a commit that referenced this issue May 16, 2024
@connoratrug
feat: Split up cohort view general design into two sections: General …
04e03c5 
…design and Population and add some missing data items

Closes #3609
@connoratrug connoratrug mentioned this issue May 16, 2024
Merged
@connoratrug connoratrug linked a pull request May 16, 2024 that will close this issue
feat: Split up cohort view general design into two sections: General … #3760
Merged
@connoratrug connoratrug self-assigned this May 16, 2024
connoratrug added a commit that referenced this issue May 22, 2024
@connoratrug
feat: Split up cohort view general design into two sections: General … (
13e400c 
#3760)

feat: Split up cohort view general design into two sections: General design and Population and add some missing data items

Closes #3609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connoratrug connoratrug

Labels
priority Features/bugs that we should not let wait ssr-catalogue ssr-pretest
Projects
None yet
Milestone
Sprint 221
Development

Successfully merging a pull request may close this issue.

feat: Split up cohort view general design into two sections: General … molgenis/molgenis-emx2
5 participants
@mswertz @esthervanenckevort @BrendaHijmans @connoratrug @EleanorHyde-UMCG