From 42933650394df3ab4cf8ca08109a11aa12695ca4 Mon Sep 17 00:00:00 2001
From: "Oliver B. Fischer" <o.b.fischer@swe-blog.net>
Date: Sat, 26 Jun 2021 00:24:56 +0200
Subject: [PATCH] Removal of not needed calls to toString() in the code base

Fixes #466
 o Removed not needed calls to toString() to improve the code base
---
 .../mojo/versions/DependencyUpdatesXmlRenderer.java         | 2 +-
 .../mojo/versions/DisplayDependencyUpdatesMojo.java         | 2 +-
 .../codehaus/mojo/versions/DisplayParentUpdatesMojo.java    | 2 +-
 .../java/org/codehaus/mojo/versions/LockSnapshotsMojo.java  | 2 +-
 .../codehaus/mojo/versions/PluginUpdatesXmlRenderer.java    | 2 +-
 .../org/codehaus/mojo/versions/UnlockSnapshotsMojo.java     | 2 +-
 .../java/org/codehaus/mojo/versions/UpdateParentMojo.java   | 2 +-
 .../org/codehaus/mojo/versions/UseLatestReleasesMojo.java   | 6 +++---
 .../org/codehaus/mojo/versions/UseLatestSnapshotsMojo.java  | 4 ++--
 .../org/codehaus/mojo/versions/UseLatestVersionsMojo.java   | 2 +-
 .../java/org/codehaus/mojo/versions/UseReleasesMojo.java    | 4 ++--
 .../mojo/versions/ordering/VersionComparatorsTest.java      | 2 +-
 12 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/main/java/org/codehaus/mojo/versions/DependencyUpdatesXmlRenderer.java b/src/main/java/org/codehaus/mojo/versions/DependencyUpdatesXmlRenderer.java
index 90a2cb284..d5ca9983e 100644
--- a/src/main/java/org/codehaus/mojo/versions/DependencyUpdatesXmlRenderer.java
+++ b/src/main/java/org/codehaus/mojo/versions/DependencyUpdatesXmlRenderer.java
@@ -106,7 +106,7 @@ public void render()
         try
         {
             pw = new PrintWriter( outputFileName, "UTF8" );
-            pw.print( sb.toString() );
+            pw.print( sb );
             pw.close();
         }
         catch ( IOException e )
diff --git a/src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java b/src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
index a851263bd..aa0fe87e9 100644
--- a/src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
@@ -434,7 +434,7 @@ private void logUpdates( Map<Dependency, ArtifactVersions> updates, String secti
                     latest = null;
                 }
             }
-            String right = " " + ( latest == null ? current : current + " -> " + latest.toString() );
+            String right = " " + ( latest == null ? current : current + " -> " + latest );
             List<String> t = latest == null ? usingCurrent : withUpdates;
             if ( right.length() + left.length() + 3 > INFO_PAD_SIZE )
             {
diff --git a/src/main/java/org/codehaus/mojo/versions/DisplayParentUpdatesMojo.java b/src/main/java/org/codehaus/mojo/versions/DisplayParentUpdatesMojo.java
index 00e882a2d..1ad6289d7 100644
--- a/src/main/java/org/codehaus/mojo/versions/DisplayParentUpdatesMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/DisplayParentUpdatesMojo.java
@@ -121,7 +121,7 @@ public void execute()
             buf.append( ' ' );
             buf.append( currentVersion );
             buf.append( " -> " );
-            buf.append( artifactVersion.toString() );
+            buf.append( artifactVersion );
             logLine( false, buf.toString() );
         }
     }
diff --git a/src/main/java/org/codehaus/mojo/versions/LockSnapshotsMojo.java b/src/main/java/org/codehaus/mojo/versions/LockSnapshotsMojo.java
index e3a5fdd50..7ea75925b 100644
--- a/src/main/java/org/codehaus/mojo/versions/LockSnapshotsMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/LockSnapshotsMojo.java
@@ -147,7 +147,7 @@ private void lockParentSnapshot( ModifiedPomXMLEventReader pom, MavenProject par
             {
                 if ( PomHelper.setProjectParentVersion( pom, lockedParentVersion ) )
                 {
-                    getLog().info( "Locked parent " + parentArtifact.toString() + " to version "
+                    getLog().info( "Locked parent " + parentArtifact + " to version "
                         + lockedParentVersion );
                 }
             }
diff --git a/src/main/java/org/codehaus/mojo/versions/PluginUpdatesXmlRenderer.java b/src/main/java/org/codehaus/mojo/versions/PluginUpdatesXmlRenderer.java
index 6cc5bf23a..597749498 100644
--- a/src/main/java/org/codehaus/mojo/versions/PluginUpdatesXmlRenderer.java
+++ b/src/main/java/org/codehaus/mojo/versions/PluginUpdatesXmlRenderer.java
@@ -95,7 +95,7 @@ public void render()
         try
         {
             pw = new PrintWriter( outputFileName, "UTF8" );
-            pw.print( sb.toString() );
+            pw.print( sb );
             pw.close();
         }
         catch ( IOException e )
diff --git a/src/main/java/org/codehaus/mojo/versions/UnlockSnapshotsMojo.java b/src/main/java/org/codehaus/mojo/versions/UnlockSnapshotsMojo.java
index 8954b4639..317eadd75 100644
--- a/src/main/java/org/codehaus/mojo/versions/UnlockSnapshotsMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/UnlockSnapshotsMojo.java
@@ -141,7 +141,7 @@ private void unlockParentSnapshot( ModifiedPomXMLEventReader pom, MavenProject p
             String unlockedParentVersion = versionMatcher.replaceFirst( "-SNAPSHOT" );
             if ( PomHelper.setProjectParentVersion( pom, unlockedParentVersion ) )
             {
-                getLog().info( "Unlocked parent " + parentArtifact.toString() + " to version "
+                getLog().info( "Unlocked parent " + parentArtifact + " to version "
                     + unlockedParentVersion );
             }
         }
diff --git a/src/main/java/org/codehaus/mojo/versions/UpdateParentMojo.java b/src/main/java/org/codehaus/mojo/versions/UpdateParentMojo.java
index 840c6a034..14020a3e8 100644
--- a/src/main/java/org/codehaus/mojo/versions/UpdateParentMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/UpdateParentMojo.java
@@ -120,7 +120,7 @@ protected void update( ModifiedPomXMLEventReader pom )
 
         if ( PomHelper.setProjectParentVersion( pom, artifactVersion.toString() ) )
         {
-            getLog().debug( "Made an update from " + currentVersion + " to " + artifactVersion.toString() );
+            getLog().debug( "Made an update from " + currentVersion + " to " + artifactVersion );
         }
     }
 
diff --git a/src/main/java/org/codehaus/mojo/versions/UseLatestReleasesMojo.java b/src/main/java/org/codehaus/mojo/versions/UseLatestReleasesMojo.java
index fa0d1b0ae..ab8b948f7 100644
--- a/src/main/java/org/codehaus/mojo/versions/UseLatestReleasesMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/UseLatestReleasesMojo.java
@@ -157,7 +157,7 @@ private void useLatestReleases( ModifiedPomXMLEventReader pom, Collection<Depend
                 }
 
                 ArtifactVersion selectedVersion = new DefaultArtifactVersion( version );
-                getLog().debug( "Selected version:" + selectedVersion.toString() );
+                getLog().debug( "Selected version: " + selectedVersion );
 
                 getLog().debug( "Looking for newer versions of " + toString( dep ) );
                 ArtifactVersions versions = getHelper().lookupArtifactVersions( artifact, false );
@@ -172,9 +172,9 @@ private void useLatestReleases( ModifiedPomXMLEventReader pom, Collection<Depend
                     {
                         if ( artifact.getId().equals( getProject().getParentArtifact().getId() ) && isProcessingParent() )
                         {
-                            if ( PomHelper.setProjectParentVersion( pom, newVersion.toString() ) )
+                            if ( PomHelper.setProjectParentVersion( pom, newVersion ) )
                             {
-                                getLog().debug( "Made parent update from " + version + " to " + newVersion.toString() );
+                                getLog().debug( "Made parent update from " + version + " to " + newVersion );
                             }
                         }
                     }
diff --git a/src/main/java/org/codehaus/mojo/versions/UseLatestSnapshotsMojo.java b/src/main/java/org/codehaus/mojo/versions/UseLatestSnapshotsMojo.java
index 71c392a2f..6867642e8 100644
--- a/src/main/java/org/codehaus/mojo/versions/UseLatestSnapshotsMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/UseLatestSnapshotsMojo.java
@@ -183,7 +183,7 @@ private void useLatestSnapshots( ModifiedPomXMLEventReader pom, Collection<Depen
                         snapshotsOnly.add( artifactVersion );
                     }
                 }
-                getLog().debug("Snapshot Only versions " + snapshotsOnly);
+                getLog().debug( "Snapshot Only versions " + snapshotsOnly );
 
                 ArtifactVersion[] filteredVersions = majorMinorIncfilter.filter( selectedVersion,
                                                                                 (ArtifactVersion[]) snapshotsOnly.toArray(
@@ -200,7 +200,7 @@ private void useLatestSnapshots( ModifiedPomXMLEventReader pom, Collection<Depen
                         {
                             if ( PomHelper.setProjectParentVersion( pom, latestVersion ) )
                             {
-                                getLog().debug( "Made parent update from " + version + " to " + latestVersion.toString() );
+                                getLog().debug( "Made parent update from " + version + " to " + latestVersion );
                             }
                         }
                     }
diff --git a/src/main/java/org/codehaus/mojo/versions/UseLatestVersionsMojo.java b/src/main/java/org/codehaus/mojo/versions/UseLatestVersionsMojo.java
index 6b34a8665..d15c45395 100644
--- a/src/main/java/org/codehaus/mojo/versions/UseLatestVersionsMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/UseLatestVersionsMojo.java
@@ -150,7 +150,7 @@ private void useLatestVersions( ModifiedPomXMLEventReader pom, Collection<Depend
             }
 
             ArtifactVersion selectedVersion = new DefaultArtifactVersion( version );
-            getLog().debug( "Selected version:" + selectedVersion.toString() );
+            getLog().debug( "Selected version:" + selectedVersion );
 
             getLog().debug( "Looking for newer versions of " + toString( dep ) );
             ArtifactVersions versions = getHelper().lookupArtifactVersions( artifact, false );
diff --git a/src/main/java/org/codehaus/mojo/versions/UseReleasesMojo.java b/src/main/java/org/codehaus/mojo/versions/UseReleasesMojo.java
index 13ebbcd7b..127bf7809 100644
--- a/src/main/java/org/codehaus/mojo/versions/UseReleasesMojo.java
+++ b/src/main/java/org/codehaus/mojo/versions/UseReleasesMojo.java
@@ -174,7 +174,7 @@ else if ( failIfNotReplaced )
                 {
                     if ( PomHelper.setProjectParentVersion( pom, finalVersion.toString() ) )
                     {
-                        getLog().info( "Updated " + toString( project ) + " to version " + finalVersion.toString() );
+                        getLog().info( "Updated " + toString( project ) + " to version " + finalVersion );
                     }
                 }
                 else
@@ -255,7 +255,7 @@ private void rangeMatching( ModifiedPomXMLEventReader pom, Dependency dep, Strin
             if ( PomHelper.setDependencyVersion( pom, dep.getGroupId(), dep.getArtifactId(), version,
                                                  finalVersion.toString(), getProject().getModel() ) )
             {
-                getLog().info( "Updated " + toString( dep ) + " to version " + finalVersion.toString() );
+                getLog().info( "Updated " + toString( dep ) + " to version " + finalVersion );
             }
         }
         else
diff --git a/src/test/java/org/codehaus/mojo/versions/ordering/VersionComparatorsTest.java b/src/test/java/org/codehaus/mojo/versions/ordering/VersionComparatorsTest.java
index 6741b0333..be51e5bfc 100644
--- a/src/test/java/org/codehaus/mojo/versions/ordering/VersionComparatorsTest.java
+++ b/src/test/java/org/codehaus/mojo/versions/ordering/VersionComparatorsTest.java
@@ -64,7 +64,7 @@ public void assertLater(String version, VersionComparator instance) {
         int count = instance.getSegmentCount( v1 );
         for (int i = 0; i < count; i++) {
             ArtifactVersion v2 = instance.incrementSegment( v1, i );
-            assertTrue(v1.toString() + " < " + v2.toString(), instance.compare( v1, v2 ) < 0);
+            assertTrue(v1 + " < " + v2, instance.compare(v1, v2 ) < 0);
         }
     }
 }