Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdatePropertiesMojo processes parent POMs #837

Closed
jarmoniuk opened this issue Dec 1, 2022 · 2 comments · Fixed by #838
Closed

UpdatePropertiesMojo processes parent POMs #837

jarmoniuk opened this issue Dec 1, 2022 · 2 comments · Fixed by #838
Labels
enhancement
Milestone
2.14.0

Comments

@jarmoniuk
Copy link
Contributor

UpdatePropertiesMojo traverses parent POMs in order to find and update properties. However, this is not necessary, only adds to chatter of the mojo, since parent POMs won't be able to be updated anyway.

As a side thing, change recorder does contain changes even if the POM has not been modified.

Seen in #793
@jarmoniuk jarmoniuk mentioned this issue Dec 1, 2022
Closed
@jarmoniuk
Copy link
Contributor Author

Edit -- it does matter after all if the child POM redefines a property defined and used in the parent. - #582

So, I'll add includeParent, equal to true.

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Dec 1, 2022
@jarmoniuk
Resolves mojohaus#837: Add includeParent (default false) to UpdatePro…
a742a88 
…pertiesMojo
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Dec 1, 2022
@jarmoniuk
Resolves mojohaus#837: Add includeParent (default true) to UpdateProp…
3689b13 
…ertiesMojo
@jarmoniuk jarmoniuk mentioned this issue Dec 1, 2022
Merged
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Dec 2, 2022
@jarmoniuk
Resolves mojohaus#837: Add includeParent (default true) to UpdateProp…
35372a8 
…ertiesMojo
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Dec 2, 2022
@jarmoniuk
Resolves mojohaus#837: Add includeParent (default true) to UpdateProp…
67035ad 
…ertiesMojo
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Dec 2, 2022
@jarmoniuk
Resolves mojohaus#837: Add includeParent (default true) to UpdateProp…
b324f5c 
…ertiesMojo
@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Dec 2, 2022 •
edited

@slawekjaranowski please resolve when #838 is merged

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Dec 2, 2022
@jarmoniuk
Resolves mojohaus#837: Add includeParent (default true) to UpdateProp…
122d4f7 
…ertiesMojo
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Dec 2, 2022
@jarmoniuk
Resolves mojohaus#837: Add includeParent (default true) to UpdateProp…
c0a951d 
…ertiesMojo
@slawekjaranowski slawekjaranowski linked a pull request Dec 3, 2022 that will close this issue
Resolves #837: Add includeParent (default true) to UpdatePropertiesMojo #838
Merged
slawekjaranowski pushed a commit that referenced this issue Dec 3, 2022
@jarmoniuk @slawekjaranowski
Resolves #837: Add includeParent (default true) to UpdatePropertiesMojo
bc10d1a
@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Dec 3, 2022
@jarmoniuk jarmoniuk mentioned this issue Feb 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.14.0
2 participants
@jarmoniuk @slawekjaranowski