Set goal with newVersion and oldVersion arguments specified fails to update only the versions which matches the oldVersion and updates all the versions

[soselamet]

Set goal with newVersion and oldVersion arguments specified fails to update only the versions which matches the oldVersion and updates all the versions.

Example :
command line / mvn versions:set -DnewVersion="TEST" -DoldVersion="TEST2"

Sample maven execution output log lines :

[INFO] Processing change of com.some.obscure.company.someniftymodule-parent:TEST2 -> TEST
.
.
.
[INFO] Updating project com.some.obscure.company.someniftymodule-document-parent
[INFO] from version 0.101.1-SNAPSHOT to TEST

Possible Solution :
Please see the diff file in the zip archive below for the possible fix.

oldVersion_fix.zip

[jarmoniuk]

Would you like to make a PR with your changes?

Your diff breaks a few integration tests:

[ERROR] The following builds failed:
[ERROR] *  it-set-004/pom.xml
[ERROR] *  it-set-007/pom.xml
[ERROR] *  it-set-008/pom.xml
[ERROR] *  it-set-017-issue-321/pom.xml

I haven't thought of the issue yet.

[jarmoniuk]

I was able to reproduce the issue.

It does not occur if the artifact with the given oldVersion is found in the reactor.

Strangely, if the artifact with the given version is not found, then the root model is changed anyway! I don't understand the reason for it, need to see why this has been done like that. Obviously, as mentioned earlier, your change breaks a few tests. It could have also been done earlier in the stack, in the main method (execute).

However, we're dealing with old code, and, as I said, I need to undestand the reason it's been done like that first in the first place. 😆

It is very likely that I'll rewrite the whole goal.

[soselamet]

Thank you for taking this issue in your focus.

The diff I shared was a quick and experimental snippet that was not intended to be a PR level contribution.

I guess integration tests are not executed as part of the regular maven install profile so I didn't observe any test failure. 😃

Please let me know if there is a need for direct contribution via a PR.