Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: display update information for ranges #767

Closed
sultan opened this issue Oct 18, 2022 · 6 comments
Closed

Enhancement: display update information for ranges #767

sultan opened this issue Oct 18, 2022 · 6 comments
Labels

Comments

@sultan
Copy link
Contributor

sultan commented Oct 18, 2022

when one uses ranges everywhere the reports are blank which does not help.

image

with range [2.0,3) the user could benefit from:

  • summary suggest update to, let's say, [2.1,3)
  • details also display omitted version to let them know major versions exist

a blank report wrongly let the user believe no major version exists when there are

we should let them know there new versions, but outside the range they chose.

@sultan
Copy link
Contributor Author

sultan commented Oct 30, 2022

note:
the property report has the major versions (outside range) shown, but lacks minor ones (inside range not shown)
the dependencies report has none shown

suggestions:
add a "resolved version" column
accept all versions greater than lowest bound in search, and mark outside ones with asterisk or something of the like (see include snapshot for comparison)

@sultan sultan changed the title Enhancement: make report not useless Enhancement: make report more usefull Oct 30, 2022
@jarmoniuk
Copy link
Contributor

Hi, are you still working on this?

@sultan
Copy link
Contributor Author

sultan commented Nov 23, 2022

Still on my todo list. I hope to get on it again anytime. Feel free to merge your prs. The main difficulty with this pr is I may need another api, Where ranges aren't used to filter out. that would make the range attribute useless in the api I need. I can try but any advice appreciated

@jarmoniuk
Copy link
Contributor

I'll check 👍

@sultan
Copy link
Contributor Author

sultan commented Nov 23, 2022

note to self:

  • one solution to my problem requires rework the cache to add the method as parameter (lambda),
  • another solution is changing the method getVersionsInRange of class PropertyUpdatesReportRenderer not to filter but returning the range/restrictions and use it to label the versions with *

@sultan sultan changed the title Enhancement: make report more usefull Enhancement: display update information for ranges Nov 23, 2022
Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants