Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log changes to a machine-readable file #356

Closed
io7m opened this issue Jul 7, 2019 · 8 comments
Closed

Log changes to a machine-readable file #356

io7m opened this issue Jul 7, 2019 · 8 comments

Comments

@io7m
Copy link
Contributor

io7m commented Jul 7, 2019

I'm writing a CI task that's designed to periodically update all the dependencies of a project to the latest version (and check that the project still builds and that all tests pass afterwards). The task uses versions:use-latest-releases and versions:update-properties.

In order to produce nice commit and changelog messages, I need access to the changes that the plugin made. I've defined a very simple XML format (with an XSD schema) and introduced a ChangeRecorder interface that logs updates. I don't know the versions plugin codebase very well and I'm not sure if I've captured all of the updates correctly.

https://github.com/io7m/versions-maven-plugin/commits/changerecorder

By default, the change recorder is switched off. In order to switch it on, use the -DchangeRecorderFormat=xml property.

I also can't work out how to run individual integration tests either from the IDE or the command line which makes writing integration tests unnecessarily difficult (each test run entails running the whole suite, which takes 15 minutes).

@io7m
Copy link
Contributor Author

io7m commented Jul 7, 2019

For future reference: Individual integration tests can be executed with -Dinvoker.test=xyz, where xyz is the test name.

@mfriedenhagen
Copy link
Member

In general I think this is useful. In your branch you have reformatted the code and changed the order of imports which makes it harder for others to review your changes.

@io7m
Copy link
Contributor Author

io7m commented Aug 27, 2019

I tried to do as little reformatting as possible, using the closest IDE style settings to the existing code as I could - I actually used the maven IDEA code style file. I believe that the formatting changes I did make moved the existing code closer to the stated style guidelines.

Is there anything I can do about this?

@io7m
Copy link
Contributor Author

io7m commented Jun 24, 2020

It's coming up to a year since I filed this, and although I've temporarily been working on other projects, I'm still interested in these changes.

If formatting is the only issue here, can I at least get a set of machine-readable style rules that I can apply to my fork to make it easier to integrate here? I used the official Maven code style file.

I'm a little sad to see this still sitting here gathering dust after all this time.

@mfriedenhagen
Copy link
Member

Hello,
I am not sure what you expect here, you did not create a pull request, did you?

@io7m
Copy link
Contributor Author

io7m commented Jun 25, 2020

Hello!

I can certainly create a pull request. My reading of the README file lead me to think that the PR wouldn't be looked at unless there was some consensus in the associated ticket. I should be able to get to that this weekend. 👍

io7m added a commit to io7m/versions-maven-plugin that referenced this issue Jun 27, 2020
This provides a ChangeRecorder interface that logs changes to a
machine-readable XML file whenever a pom.xml file is updated.

Affects: mojohaus#356
@io7m io7m mentioned this issue Jun 27, 2020
io7m added a commit to io7m/versions-maven-plugin that referenced this issue Jun 27, 2020
This provides a ChangeRecorder interface that logs changes to a
machine-readable XML file whenever a pom.xml file is updated.

Affects: mojohaus#356
io7m added a commit to io7m/versions-maven-plugin that referenced this issue Jun 27, 2020
This provides a ChangeRecorder interface that logs changes to a
machine-readable XML file whenever a pom.xml file is updated.

Affects: mojohaus#356
@github-actions github-actions bot added the Stale label Sep 13, 2021
@slachiewicz slachiewicz reopened this Sep 20, 2021
@io7m
Copy link
Contributor Author

io7m commented Sep 20, 2021

I was just notified that someone was still interested in this, but I don't see the message here where I was expecting to see it...

Edit: The message was in the PR.

@github-actions github-actions bot removed the Stale label Sep 21, 2021
io7m added a commit to io7m/versions-maven-plugin that referenced this issue Oct 7, 2021
This provides a ChangeRecorder interface that logs changes to a
machine-readable XML file whenever a pom.xml file is updated.

Affects: mojohaus#356
slachiewicz pushed a commit that referenced this issue Apr 23, 2022
This provides a ChangeRecorder interface that logs changes to a
machine-readable XML file whenever a pom.xml file is updated.

Closes #416 #356
@stefanseifert
Copy link
Contributor

implemented in #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants