Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect implementation of org.codehaus.mojo.versions.CompareDependenciesMojo#getRemoteMavenProject method #1067

Open
rimvydasv opened this issue Apr 12, 2024 · 1 comment

Comments

@rimvydasv
Copy link

CompareDependenciesMojo.java
Lines 260 - 266

ProjectBuildingResult result = projectBuilder.build(
remoteArtifact,
true,
PomHelper.createProjectBuilderRequest(
session,
r -> r.setProcessPlugins(false),
r -> r.setRemoteRepositories(session.getCurrentProject().getPluginArtifactRepositories())));

As far as I understand the last line should be:
r -> r.setRemoteRepositories(session.getCurrentProject().getRemoteArtifactRepositories())));

@slawekjaranowski
Copy link
Member

You can try to change implementation - and we see if ITs pass.

You can also add a specific IT which discover your problem.

We can also build set of getPluginArtifactRepositories and getRemoteArtifactRepositories and pass it as remote repositories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants