diff --git a/src/it/it-resolve-ranges-issue-442/invoker.properties b/src/it/it-resolve-ranges-issue-442/invoker.properties new file mode 100644 index 000000000..b4d5204b0 --- /dev/null +++ b/src/it/it-resolve-ranges-issue-442/invoker.properties @@ -0,0 +1,2 @@ +invoker.goals=-X ${project.groupId}:${project.artifactId}:${project.version}:resolve-ranges +invoker.buildResult=failure diff --git a/src/it/it-resolve-ranges-issue-442/pom.xml b/src/it/it-resolve-ranges-issue-442/pom.xml new file mode 100644 index 000000000..0ab78962f --- /dev/null +++ b/src/it/it-resolve-ranges-issue-442/pom.xml @@ -0,0 +1,22 @@ + + 4.0.0 + + localhost + it-resolve-ranges-issues-442 + 1.0 + pom + resolve-ranges IT issue 442 + + Test that resolve-range chokes (correctly) on missing version in dependencyManagement + + + + + junit + junit + + + + + diff --git a/src/it/it-resolve-ranges-issue-442/verify.groovy b/src/it/it-resolve-ranges-issue-442/verify.groovy new file mode 100644 index 000000000..fae229f11 --- /dev/null +++ b/src/it/it-resolve-ranges-issue-442/verify.groovy @@ -0,0 +1,2 @@ +def buildLogFile = new File(basedir, "build.log") +assert buildLogFile.text.contains("MojoExecutionException: Found invalid managed dependency junit:junit:jar without a version") \ No newline at end of file diff --git a/src/main/java/org/codehaus/mojo/versions/ResolveRangesMojo.java b/src/main/java/org/codehaus/mojo/versions/ResolveRangesMojo.java index 00a6c50bf..5ff16462a 100644 --- a/src/main/java/org/codehaus/mojo/versions/ResolveRangesMojo.java +++ b/src/main/java/org/codehaus/mojo/versions/ResolveRangesMojo.java @@ -26,6 +26,7 @@ import javax.xml.stream.XMLStreamException; +import org.apache.commons.lang3.StringUtils; import org.apache.maven.artifact.Artifact; import org.apache.maven.artifact.metadata.ArtifactMetadataRetrievalException; import org.apache.maven.artifact.versioning.ArtifactVersion; @@ -214,6 +215,11 @@ private void resolveRanges( ModifiedPomXMLEventReader pom, Collection