Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #769 #770

Merged
merged 1 commit into from Oct 20, 2022
Merged

Fixing #769 #770

merged 1 commit into from Oct 20, 2022

Conversation

jarmoniuk
Copy link
Contributor

@jarmoniuk jarmoniuk commented Oct 18, 2022 •
edited

Obvious fix + unit tests.

Please add to the release if still possible.

@jarmoniuk
Copy link
Contributor Author

@slawekjaranowski

@pzygielo

This comment was marked as off-topic.

Sign in to view
@pzygielo pzygielo mentioned this pull request Oct 18, 2022
Closed
@jarmoniuk
Copy link
Contributor Author

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

Note: "fixing" is not recognized as closing keyword and it does not link PR with issue.

Thanks

@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Oct 20, 2022
@slawekjaranowski
Copy link
Member

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests
Note: "fixing" is not recognized as closing keyword and it does not link PR with issue.

keywords can be also used in commit message - not necessary in commit subject 😄

@slawekjaranowski slawekjaranowski linked an issue Oct 20, 2022 that may be closed by this pull request
Unchanged segment == empty if allowMajorUpdates && allowMinorUpdates #769
Closed
@pzygielo

This comment was marked as off-topic.

Sign in to view
@jarmoniuk
Copy link
Contributor Author

Pls merge 😏

@slawekjaranowski slawekjaranowski merged commit 98c703e into mojohaus:master Oct 20, 2022
@jarmoniuk jarmoniuk deleted the issue-769-segment-utils branch October 20, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Unchanged segment == empty if allowMajorUpdates && allowMinorUpdates
3 participants
@jarmoniuk @pzygielo @slawekjaranowski