Implementing #684: allow providing ruleSet in POM #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmoniuk
force-pushed
the
issue-684-property-based-rules-ruleset
branch
from
73c09da
to
3731a73
Compare
slawekjaranowski
requested changes
Sep 12, 2022
There was a problem hiding this comment.
We have two methods loadRuleSet in DefaultVersionsHelper
one is called from constructor one from builder
there is logic for checking ignoredVersions and
there is logic for checking ignore Versions and creating / coping ruleSet depends on it ... it looks a little complicated
Maybe simply in order:
- if ruleSet exist in plugin configuration use it
- if rulesUri exist use it
- always add ignoredVersions to ruleSet
src/main/java/org/codehaus/mojo/versions/AbstractVersionsUpdaterMojo.java
Show resolved
Hide resolved
jarmoniuk
force-pushed
the
issue-684-property-based-rules-ruleset
branch
from
3731a73
to
4e2e521
Compare
|
Remarks applied. Please re-review. :) |
src/main/java/org/codehaus/mojo/versions/api/DefaultVersionsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/api/DefaultVersionsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/api/DefaultVersionsHelper.java
Outdated
Show resolved
Hide resolved
jarmoniuk
force-pushed
the
issue-684-property-based-rules-ruleset
branch
from
4e2e521
to
3127ac3
Compare
|
Again, applied all comments. Please review again. |
slawekjaranowski
approved these changes
Sep 13, 2022
|
@ajarmoniuk Thanks - good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing the possibility to provide the ruleSet via POM. As an extra which comes at a low cost, it will also be possible to provide just the global ignored versions via the
maven.version.ignoreproperty (property name chosen to be in line with similar properties for this plugin).Added some unit tests where it didn't come at a great runtime cost, in other cases created integration tests to test as many mojos as possible where the change occurs.
On top of that, some very minor refactoring and cleanup.
As usual, kindly please review @slawekjaranowski