Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #670: restoring allowSnapshots which was disabled in PR #665 #671

Conversation

jarmoniuk
Copy link
Contributor

@jarmoniuk jarmoniuk commented Sep 6, 2022

Fixing the problem related to snapshots in UpdateParentMojo + adding a unit test testing snapshots.

@jarmoniuk
Copy link
Contributor Author

@slawekjaranowski please review

@slawekjaranowski slawekjaranowski added this to the next-release milestone Sep 6, 2022
@pzygielo
Copy link
Contributor

pzygielo commented Sep 6, 2022

@pzygielo
Copy link
Contributor

pzygielo commented Sep 6, 2022

Still getting

[INFO] --- versions-maven-plugin:2.12.1-SNAPSHOT:update-parent (default-cli) @ parent ---
[WARNING] Not updating version: could not resolve any versions

@jarmoniuk
Copy link
Contributor Author

with what invocation arguments? did you use -DallowSnapshots ?

@pzygielo
Copy link
Contributor

pzygielo commented Sep 6, 2022

with what invocation arguments?

mvn org.codehaus.mojo:versions-maven-plugin:2.12.1-SNAPSHOT:update-parent -DparentVersion=71-SNAPSHOT -DallowSnapshots=true

@pzygielo
Copy link
Contributor

pzygielo commented Sep 6, 2022

As there is no reproducer in original issue, here's my pom:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <parent>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>mojo-parent</artifactId>
        <version>70</version>
    </parent>

    <groupId>mojohaus</groupId>
    <artifactId>issue-670</artifactId>
    <version>0.31-SNAPSHOT</version>
    <packaging>pom</packaging>

</project>

@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Sep 6, 2022

Or perhaps could you please refer to the artifacts in it-repo?
Oh, never mind 😆

@jarmoniuk jarmoniuk force-pushed the issue-670-downgrade-with-allow-snapshots branch from 4cfb878 to 2be4fa6 Compare September 6, 2022 14:08
@jarmoniuk
Copy link
Contributor Author

Thanks for the test case. Amended the PR.

…usePluginRepositories was incorrectly enabled
@jarmoniuk jarmoniuk force-pushed the issue-670-downgrade-with-allow-snapshots branch from 2be4fa6 to 8395718 Compare September 6, 2022 14:45
@jarmoniuk
Copy link
Contributor Author

Also added that test as an it.

@slawekjaranowski slawekjaranowski merged commit b14af60 into mojohaus:master Sep 6, 2022
@slawekjaranowski
Copy link
Member

@ajarmoniuk thanks for fix
@pzygielo thanks for testing

@jarmoniuk jarmoniuk deleted the issue-670-downgrade-with-allow-snapshots branch September 6, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

versions:update-parent working in 2.11.0 and not anymore in 2.12.0
3 participants