Fix for issue #648: de-shadowing the localRepository property #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add some tests or assertions in existing test to catch such error? |
|
Ok, I think it doesn't really make sense to create a unit test, and the easiest one would be to use it. If that's not too heavy. |
|
Please also add simple assertions to check if report file was created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractMavenReport from maven-reporting-impl:3.2.0 introduced the
localRepositoryproperty, which was supposed to be initialized from a parameter with the same name, and if the same was not supplied, from${localRepository}. Unfortunately, it was shadowed byAbstractVersionsReport