Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit to only artifacts that have updates and are in the dependency graph (#589) #640

Merged
merged 1 commit into from Aug 20, 2022

Conversation

jarmoniuk
Copy link
Contributor

Added onlyUpgradable, which will restrict the reports to only show upgradable artifacts, and onlyProjectDependencies, onlyProjectPlugins, which will restrict the graph of demendencyManagement/pluginManagement artifacts to the graph used in the project.

Additionally, some refactoring and improvements.

Most importantly in class AbstractVersionsReport, which redefined some of its superclass attributes in order to restrict access (?), which was apparently never used and could only create confusion. Simplified.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix some of copy paste items :-)

@slawekjaranowski
Copy link
Member

Please also change PR title and commit subject to something related with new features introduced in git.

PR title will be in release notes. Commit it git history.

@jarmoniuk jarmoniuk changed the title Implementing #589 Limit to only artifacts that have updates and are in the dependency graph (#589) Aug 20, 2022
@jarmoniuk
Copy link
Contributor Author

Review comments addressed.

…raph (mojohaus#589)

Added `onlyUpgradable`, which will restrict the reports to only show upgradable artifacts, and `onlyProjectDependencies`, `onlyProjectPlugins`, which will restrict the graph of demendencyManagement/pluginManagement artifacts to the graph used in the project.

Additionally, some refactoring and improvements.
@slawekjaranowski slawekjaranowski merged commit cd94151 into mojohaus:master Aug 20, 2022
@jarmoniuk jarmoniuk deleted the issue-589-pr branch September 1, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency-updates-report: limit to only artifacts that have updates and are in the dependency graph
2 participants