Fix for issue #582 - update-properties does not work across parent-child pom

[prodj17]

Fixed #582
o Updated PomHelper to validate version properties also across parents.

[prodj17]

@slawekjaranowski do you think you can find some time to look into this?

[slawekjaranowski]

• it looks like we can add a unit tests for PomHelper, it should be easier to check coverage by test
• what will be if in parent we will have dependencyManagment and in child dependency without version, and property
• what will be if in parent we will have dependencyManagment and in child no dependency, but only property

disclosure - I'm not know this code ... and logic looks quite complex, so will be good if someone else looks at it

[prodj17]

disclosure - I'm not know this code ... and logic looks quite complex, so will be good if someone else looks at it

The change in logic is actually quite simple, yet for some reason github diff messed up. If you hide whitespaces changes the diff looks a lot better - the changes are highlighted correctly.

The logic of dependencyManagement vs property stays the same as for a single pom. The only change there is to actually iterate over the parent poms and process those as well when looking for properties.

@olamy @bmarwell I've seen you made changes to PomHelper more recently. Do you guys think you can look into it?

[slawekjaranowski]

please change commit message to something more related what we do, eg like:

update-properties does not work across parent-child pom

pleas also squash to one commit

[prodj17]

please change commit message to something more related what we do, eg like:

update-properties does not work across parent-child pom

pleas also squash to one commit

@slawekjaranowski done

[slawekjaranowski]

ok, looks ok for me.

I will wait a few days for other comments.

[prodj17]

ok, looks ok for me.

I will wait a few days for other comments.

@slawekjaranowski Can this be merged now since there are no more comments? Is there a timeframe for the next release of the plugin? Anything that I need to do for the release?

[prodj17]

@slawekjaranowski It has been more than a week and there are no comments. Could we merge this PR?

[slawekjaranowski]

Ok.
last request, can you squash to single commit.
Of course I can do it for you.

[prodj17]

Ok. last request, can you squash to single commit. Of course I can do it for you.

@slawekjaranowski
Done. Can this be merged now?

[slawekjaranowski]

@prodj17 - thanks