Fixes #318 includes/excludes for dependencies #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonoluluHenk
changed the title
|
@stefanseifert with the last (force-)push, this pr should now be feature-complete, works-on-my-machine (tm) including Unit- and Integration-Tests. I did not find any guides regarding source-formatting. If you could provide pointers to docs (or preferrably auto-formatters :)), I'd be glad to implement your preferred code style. |
src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/versions/DisplayDependencyUpdatesMojo.java
Outdated
Show resolved
Hide resolved
|
I implemented all your review comments, time for another try? |
|
@stefanseifert any remarks for it? |
|
any news on this? |
|
Pleas squash to final one commit. |
fixes #318 implement includes/excludes for dependencies apply maven codestyle fixes #318 implement includes/excludes for dependencies bump @SInCE 2.12.0 fixes #318 implement includes/excludes for dependencies make ITs work on windows fixes #318 implement includes/excludes for dependencies switch to List<String> instead of splitting a list-style string myself fixes #318 implement includes/excludes for dependencies migrate ITs to test.properties since maven runner does some magic with "," in invoker.goals with no other workaround fix some descriptions fixes #318 implement includes/excludes for dependencies add IT for multiple comma-separated inclusion filters
|
...squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixex #318