Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update outputTimestamp #595

Closed
qoomon opened this issue Jun 5, 2022 · 5 comments · Fixed by #630
Closed

Always update outputTimestamp #595

qoomon opened this issue Jun 5, 2022 · 5 comments · Fixed by #630

Comments

@qoomon
Copy link

qoomon commented Jun 5, 2022

Current Behaviour
outputTimestamp value is only updated if versions:set has changed version value

Expected Behaviour
outputTimestamp value should be updated always if versions:set is executed or at least for -SNAPSHOT versions.

@slawekjaranowski
Copy link
Member

Maybe new parameters with values:

  • never
  • always
  • onchange

For SNAPSHOT I don't see benefit - in standard way project is always in snapshot version

@qoomon
Copy link
Author

qoomon commented Jun 13, 2022

A parameter would be awesome, however what's the disadvantage in always setting outputTimestamp?

@slawekjaranowski
Copy link
Member

In standard situation when nothing is changed also outputTimestamp should not be changed.
So my proposition is to add flags to preserve current behavior.

@qoomon
Copy link
Author

qoomon commented Aug 1, 2022

sound reasonable

slawekjaranowski pushed a commit that referenced this issue Aug 15, 2022
… never) (#595) (#630)


Co-authored-by: Andrzej Jarmoniuk <git@jarmoniuk.nl>
@qoomon
Copy link
Author

qoomon commented Aug 15, 2022

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants