Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #583 #584

Closed
wants to merge 2 commits into from
Closed

Fixed #583 #584

wants to merge 2 commits into from

Conversation

c3p0-maif
Copy link
Contributor

@c3p0-maif c3p0-maif commented Apr 15, 2022 •
edited by bmarwell

Ignoring dependency with no version in useReleases

Fixes #583

@c3p0-maif
Fixed mojohaus#583
b44c08e 
Ignoring dependency with no version in useReleases
bmarwell
bmarwell approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an NPE, therefore +1.
However, the bug only occurres on an invalid configuration. But I do not want to stand in the way here.

Can you please add an IT or unit test?

@c3p0-maif
Copy link
Contributor Author

c3p0-maif commented Apr 19, 2022 •
edited

an IT or unit test?

Hi @bmarwell I thought about adding unit tests but the lines, methods or classes I modified were apparently not covered 😞
I will lookup how to add IT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarwell bmarwell bmarwell approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use-releases throw NPE when using provided dependencies with no version
3 participants
@c3p0-maif @bmarwell @slachiewicz