Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-properties does not work across parent-child pom #582

Closed
prodj17 opened this issue Apr 13, 2022 · 3 comments · Fixed by #616
Closed

update-properties does not work across parent-child pom #582

prodj17 opened this issue Apr 13, 2022 · 3 comments · Fixed by #616

Comments

@prodj17
Copy link

prodj17 commented Apr 13, 2022

Version 2.8.1 and above

Parent POM has

<properties>
  <version.lib>1.0.0</version.lib>
</properties>

  <dependencies>
    <dependency>
      <groupId>org.example</groupId>
      <artifactId>someLib</artifactId>
      <version>${version.lib}</version>
    </dependency>
  <dependencies>

Child POM has

<properties>
  <version.lib>1.1.0</version.lib>
</properties>

The child $version.lib property is active (i.e. does control the version of someLib in use) however update-properties does not update $version.lib to latest version when run on the child POM. They will do this if the dependency on someLib exists in the child pom.

prodj17 pushed a commit to prodj17/versions-maven-plugin that referenced this issue Jul 12, 2022
 o Updated PomHelper to validate version properties also across parents.
prodj17 pushed a commit to prodj17/versions-maven-plugin that referenced this issue Jul 13, 2022
 o Updated PomHelper to validate version properties also across parents.
prodj17 pushed a commit to prodj17/versions-maven-plugin that referenced this issue Jul 13, 2022
 o Updated PomHelper to validate version properties also across parents.
prodj17 pushed a commit to prodj17/versions-maven-plugin that referenced this issue Jul 14, 2022
Fixes mojohaus#582
 o Updated PomHelper to validate version properties also across parents.
prodj17 pushed a commit to prodj17/versions-maven-plugin that referenced this issue Jul 25, 2022
Fixes mojohaus#582
 o Updated PomHelper to validate version properties also across parents.
prodj17 pushed a commit to prodj17/versions-maven-plugin that referenced this issue Jul 25, 2022
Fixes mojohaus#582
 o Updated PomHelper to validate version properties also across parents.
prodj17 pushed a commit to prodj17/versions-maven-plugin that referenced this issue Jul 25, 2022
Fixes mojohaus#582
 o Updated PomHelper to validate version properties also across parents.
slawekjaranowski pushed a commit that referenced this issue Jul 25, 2022
Fixes #582
 o Updated PomHelper to validate version properties also across parents.
@prodj17
Copy link
Author

prodj17 commented Jul 26, 2022

@slawekjaranowski Do you have a estimate when this change will be released(when is the next release cycle)?

@slawekjaranowski
Copy link
Member

We don't have a release cycle, and estimations.

You can drop a line o dev list.

@prodj17
Copy link
Author

prodj17 commented Jul 27, 2022

Hi, @stefanseifert I've seen you did the last three releases of this plugin. Are you planning to do a new release soon? My team is really looking forward for this fix to go live,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants