Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of plugin updates requiring newer Maven for building than #527

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Jan 11, 2022

for running

Separate minimal Maven version detection for projects from requirements
of plugins
This closes #526

for running

Separate minimal Maven version detection for projects from requirements
of plugins
This closes mojohaus#526
Copy link
Contributor

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good and solves the problem (i was bothered of it as well).

one remark: you removed the test class RequiredMavenVersionFinderTest completely. probably the test were not all valuable, but especially not covering all the complex parsing code in MinimalMavenBuildVersionFinder.processMavenVersionRange is bothering me - all those variants are not covered in the ITs.

@kwin
Copy link
Contributor Author

kwin commented Jan 12, 2022

probably the test were not all valuable, but especially not covering all the complex parsing code in MinimalMavenBuildVersionFinder.processMavenVersionRange is bothering me - all those variants are not covered in the ITs.

Most tests were not really useful as were mostly calls on mock objects, but the ones for parsing versions were indeed useful. Let me readd/extend those.

@stefanseifert stefanseifert merged commit dce93be into mojohaus:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determining the required Maven version for plugins is incorrect
2 participants